Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[#32][#61] added vsdbg to launch.json, added rsa-sha2-256 for ssh.net… #62

Merged
merged 2 commits into from
Jul 5, 2023

Conversation

zeusware
Copy link
Contributor

@zeusware zeusware commented Jul 2, 2023

Related: #32 #61

  • Added vsdbg to launch.json, added rsa-sha2-256 for ssh.net, added ssh.exe adapter, working version

New Features

  1. Ubuntu 22.04 LTS OpenSSH package does not support the ssh algo: ssh-rsa u intended bei generating via 'ssh-keygen -m PEM -t rsa -b 4096' by default anymore,
    Adding the RSA-SHA2-256 for SSH.Net for interpreting private keys made by ssh-keygen -m PEM -t rsa -b 4096 allowing connecting directly.
  2. vsdbg was missing in launch.json, this has been merged already
  3. Using a ppk via plink is obsolete if u gen the key via PowerShell ssh-keygen, so u have now the option to use the system integrated ssh.exe (PS 6 integrate that by default)

@DamianSuess DamianSuess added enhancement Approved new feature or enhancement not-reviewed Issue that needs reviewed labels Jul 4, 2023
@DamianSuess DamianSuess added this to the v2.1 milestone Jul 4, 2023
@DamianSuess
Copy link
Collaborator

Thanks, @zeusware!

While this PR will be reviewed and tested this week. Do you mind updating the description to clearly read the PR's intent and what it addresses? This helps keep the history system clear and tidy for future PR readers.

@zeusware
Copy link
Contributor Author

zeusware commented Jul 4, 2023

Ubuntu 22.04 LTS OpenSSH package does not supports the ssh algo: ssh-rsa u intended bei generating via 'ssh-keygen -m PEM -t rsa -b 4096' by default anymore,
Adding the rsa-sha2-256 for SSH.Net for interpreting private keys made by ssh-keygen -m PEM -t rsa -b 4096 allowing connecting directly.
2) vsdbg was missing in launch.json, this has been merged already
3) using a ppk via plink is obsolete if u gen the key via PowerShell ssh-keygen, so u have now the option to use the system integrated ssh.exe (PS 6 integrate that by default)

@DamianSuess DamianSuess self-assigned this Jul 4, 2023
@DamianSuess DamianSuess merged commit 6296f0d into SuessLabs:develop Jul 5, 2023
@DamianSuess
Copy link
Collaborator

Amazing contribution @zeusware!!
I'm going to update the release notes with credit given to you on the new addition and publish the package. Would you like me to use a formal name, or "ZeusWare"?

@zeusware
Copy link
Contributor Author

zeusware commented Jul 5, 2023

Thx ;)
I've some more in Pipe if u like.
Please use "ZeuSWarE GmbH" ,...
with best regards

@DamianSuess
Copy link
Collaborator

Thanks for getting back so quickly, Kai.

Making the update as we speak, sir. I'm doing some minor house-keeping code cleanup, which you will need to pull the latest develop branch. The release will be out by the end of today (EST) as version 2.1.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Approved new feature or enhancement not-reviewed Issue that needs reviewed
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants