Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Options Class Cleanup #50

Merged
merged 11 commits into from
Feb 14, 2023
Merged

Options Class Cleanup #50

merged 11 commits into from
Feb 14, 2023

Conversation

DamianSuess
Copy link
Collaborator

@DamianSuess DamianSuess commented Dec 6, 2022

Clean up the implementation of the UserOptions class and LaunchBuilder in preparation for custom profiles.

Tasks:

  • Added: Helpful logging of payload compression and upload in-progress status
  • Cleanup EditorConfig
  • Minor code cleanup
  • Refactor DebuggerPackager class
    • Rename and update the visibility private _optionsPagetopublic... VsixOptionsPage`
    • Deprecate DebuggerPackage's redundant properties
    • Set Logger.AutoSwitchToLinuxDbgOutput on Options Page save.
  • Rename Commands.Settings to VsixPackage - The current name is misleading
  • Refactor SSHTool
    • Remove LaunchBuilder from SshTool class.
    • Pass in only necessary connection info
    • Pass-in path to CleanDeploymentFolderAsync()

@DamianSuess DamianSuess self-assigned this Dec 6, 2022
@DamianSuess DamianSuess added the enhancement Approved new feature or enhancement label Dec 6, 2022
@DamianSuess DamianSuess added this to the v2.x milestone Dec 6, 2022
@DamianSuess DamianSuess marked this pull request as ready for review December 13, 2022 23:12
@DamianSuess DamianSuess merged commit b995658 into develop Feb 14, 2023
@DamianSuess DamianSuess deleted the feature/StaticOptions branch February 14, 2023 16:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Approved new feature or enhancement
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

1 participant