Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[2.0] Check if cURL is installed #28

Merged
merged 9 commits into from
Aug 16, 2022
Merged

[2.0] Check if cURL is installed #28

merged 9 commits into from
Aug 16, 2022

Conversation

DamianSuess
Copy link
Collaborator

@DamianSuess DamianSuess commented May 4, 2022 •
edited
Loading

Updates:

  • Added: Auto-install cURL if it's not found; required by VSDBG installation validator
  • Update: LaunchBuilder now uses RemoteVsDbgFullPath (./path/to/vsdbg)
  • Update: Renamed RemoteVsDbgPath to RemoteVsDbgBasePath for clarity
  • Fixed: SshTool.TryInstallVsDbg pulls default path from Options page (previously hard-coded)

Breaking Change

  • Fixed: Options window's default VSDBG is now the base path and not the full executable's path. Before: ~/vsdbg/vsdbg. Now: ~/.vsdbg

References

@DamianSuess DamianSuess added the enhancement Approved new feature or enhancement label May 4, 2022
@DamianSuess DamianSuess added this to the v2.x milestone May 4, 2022
@DamianSuess DamianSuess self-assigned this May 4, 2022
@DamianSuess
* Added Constants class
b36122a 
* Update: Options' VsDbg now uses the folder path and now full path of the executable. (**BREAKING CHANGE**)
* Update: LaunchBuilder now uses RemoteVsDbgFullPath (`./path/to/vsdbg`)
* Update: Renamed `RemoteVsDbgPath` to `RemoteVsDbgBasePath` for clarity
* Fixed: SshTool.TryInstallVsDbg pulls default path from Options page (previously hard-coded)
@DamianSuess
* Update: Options' sample for remote VsDbg install path
6cbcff9
@DamianSuess
Copy link
Collaborator Author

NOTE:

  • Since the default VSDBG setting has changed, we need a migration strategy
  • Considering removing the option to set the VsDbg path and align with the default used by Visual Studio (~/.vs-debugger/vs2022). This would take care of breaking changes.

DamianSuess
DamianSuess commented May 17, 2022
View reviewed changes
src/VsLinuxDebugger/Core/Constants.cs

public const string DefaultVsdbg2019Path = "~/.vsdbg/vs2019";
public const string DefaultVsdbg2022Path = "~/.vsdbg/vs2022";
public const string DefaultVsdbgBasePath = "~/.vsdbg";
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Consider changing to ~/.vs-debugger

DamianSuess
DamianSuess commented May 17, 2022
View reviewed changes
src/VsLinuxDebugger/OptionsPages/OptionsPage.DotNet.cs
[Description(
"Root folder of Visual Studio Debugger. " +
"(Samples: `~/.vsdbg`, `~/.vs-debugger/vs2022`)")]
public string RemoteVsDbgRootPath { get; set; } = Constants.DefaultVsdbgBasePath;
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Breaking change

@DamianSuess DamianSuess mentioned this pull request May 17, 2022
Closed
@DamianSuess DamianSuess linked an issue Aug 16, 2022 that may be closed by this pull request
[2.0] Detect if cURL is installed, if not, install it. #27
Closed
@DamianSuess DamianSuess changed the title Check if cURL is installed [2.0] Check if cURL is installed Aug 16, 2022
@DamianSuess DamianSuess merged commit 8014b4d into develop Aug 16, 2022
@DamianSuess DamianSuess deleted the feature/AutoInstallCurl branch August 16, 2022 16:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@DamianSuess DamianSuess

Labels
enhancement Approved new feature or enhancement
Projects
VS Linux Debugger
Status: Done
Milestone
v2.0
Development

Successfully merging this pull request may close these issues.

[2.0] Detect if cURL is installed, if not, install it.
1 participant
@DamianSuess