-
Notifications
You must be signed in to change notification settings - Fork 37
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Clean up repetitive code in CraftTreePatcher.cs #526
Clean up repetitive code in CraftTreePatcher.cs #526
Conversation
CLA Assistant Lite bot All contributors have signed the CLA ✍️ ✅ |
I have read the CLA Document and I hereby sign the CLA |
Don't do anything with this yet, gotta test it |
internal static Dictionary<CraftTree.Type, List<Node>> NodesToRemove = new(); | ||
internal static Dictionary<CraftTree.Type, List<CraftingNode>> CraftingNodes = new(); | ||
internal static Dictionary<CraftTree.Type, List<TabNode>> TabNodes = new(); | ||
internal static Dictionary<CraftTree.Type, CraftTree> CachedTrees = new(); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I might be blind but it looks like you remove CachedTrees
here (not just moved it) and it's used further down on line 93/94.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Potentially a consequence of just pulling this one commit from amongst your others
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Also somehow turned the Dictionaries into lists.. lol
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks like it reverted parts of my commit from the other day
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah that explains both issues, Ramune didn't have those when they made this commit. CachedTrees didn't exist and they weren't* dictionaries at the point when the commit was made.
Edited to fix 2am brain
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I mean they should be dictionaries.
Changes made in this pull request
Breaking changes