Skip to content

Change typing stub to make pyright happy. #172

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Thom1729 merged 1 commit into from
Jul 5, 2021
Merged

Change typing stub to make pyright happy. #172

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 4 additions & 2 deletions st3/sublime_lib/_compat/typing.py
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,6 @@
try:
import sys

if sys.version_info >= (3, 8, 0):
from typing import * # noqa: F401, F403
except ImportError:
else:
from .typing_stubs import * # type: ignore # noqa: F401, F403
Comment on lines +3 to 6
Copy link
Member

@rchl rchl May 23, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should it be something like this instead so that the Sublime Text typing depedency is used when installed?

if sys.version_info >= (3, 8, 0):
    from typing import *  # noqa: F401, F403
else:
    try:
        from typing import *  # noqa: F401, F403
    except ImportError:
        from .typing_stubs import *  # type: ignore # noqa: F401, F403

Although I'm not sure what would be the point really. It would not change the runtime behavior and is not needed for pyright either.

Copy link
Member Author

@Thom1729 Thom1729 Jul 5, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Probably not needed, and we've had issues with a similar approach with enum.