-
Notifications
You must be signed in to change notification settings - Fork 4
Add SettingsListener. #166
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
Thom1729
wants to merge
13
commits into
master
Choose a base branch
from
settings-listener
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from 1 commit
Commits
Show all changes
13 commits
Select commit
Hold shift + click to select a range
d2d4efd
Add SettingsListener.
Thom1729 9aa7da2
Use get_selector.
Thom1729 11b67fd
More tests and fix for GlobalSettingsListener.
Thom1729 0adac86
Merge branch 'master' into settings-listener
Thom1729 3377d2f
Merge branch 'master' into settings-listener
Thom1729 7ab35d0
First draft of docs.
Thom1729 1f7bc82
First draft of docs.
Thom1729 15803a8
Don't manually call __del__
Thom1729 f441ec0
Merge branch 'master' into settings-listener
Thom1729 50a2a01
Add error handling when SETTINGS_NAME is missing.
Thom1729 2571d55
Fix line length.
Thom1729 031f49b
Add projection documentation.
Thom1729 508d685
Move string case to top of projection docs.
Thom1729 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Some comments aren't visible on the classic Files Changed page.
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
18 changes: 11 additions & 7 deletions
18
tests/settings_listener_package/settings_listener_plugin.py
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,20 +1,24 @@ | ||
| from sublime_lib import ViewSettingsListener, GlobalSettingsListener, on_setting_changed | ||
| import sublime_lib | ||
| from sublime_lib import on_setting_changed, ResourcePath | ||
|
|
||
|
|
||
| __all__ = ['FooSettingListener', 'GlobalFooSettingListener'] | ||
|
|
||
|
|
||
| class FooSettingListener(ViewSettingsListener): | ||
| PACKAGE_NAME = ResourcePath.from_file_path(__file__).package | ||
|
|
||
|
|
||
| class FooSettingListener(sublime_lib.ViewSettingsListener): | ||
| @on_setting_changed('foo') | ||
| def foo_changed(self, new_value: object, old_value: object): | ||
| changes = self.settings.get('changes', []) | ||
| self.settings.set('changes', changes + [[new_value, old_value]]) | ||
| print('foo_changed', new_value, old_value, changes) | ||
|
|
||
|
|
||
| class GlobalFooSettingListener(GlobalSettingsListener): | ||
| SETTINGS_NAME = 'Baz.sublime-settings' | ||
| class GlobalFooSettingListener(sublime_lib.GlobalSettingsListener): | ||
| SETTINGS_NAME = PACKAGE_NAME + '.sublime-settings' | ||
|
|
||
| @on_setting_changed('foobar') | ||
| @on_setting_changed('foo') | ||
| def foo_changed(self, new_value: object, old_value: object): | ||
| print('foo_changed', new_value, old_value) | ||
| changes = self.settings.get('changes', []) | ||
| self.settings.set('changes', changes + [[new_value, old_value]]) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.