-
-
Notifications
You must be signed in to change notification settings - Fork 889
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Image properties and onImageTap for the richTextParser, plus some fixes #90
Conversation
- Added onTap support for Image widgets that are parsed by the richTextParser - Added ImageProperties to the richTextParser - Fixed 'alt' HTML element - it was not working before due to the if..else if.. confusion
@Sub6Resources Please take a look whenever you have time. |
Since your are it. It would be nice if you add |
@The-Redhat When this PR gets merged, you should be able to use the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good. Thank you!
Can onImageTap Function consider adding image url or image data as parameters ? This makes it easy to do some other processing when onTap, such as a large image preview. Thanks! |
@w4mxl I will create a new PR for it. |
@andreyeurope Sounds good. Thank you! |
As we have talked, I have added an image properties attribute to the flutter_html library.
More than that, I have previously tried to use the 'alt' HTML element, but was not working.
I have fixed that.
I have also added onImageTap support for the richText parser.
Note: I don't know how you like your project structured, but I usually use a different file for a different class.