Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug: newline character after <br> should not be shown as space. #218

Closed
ngaurav opened this issue Jan 16, 2020 · 6 comments
Closed

Bug: newline character after <br> should not be shown as space. #218

ngaurav opened this issue Jan 16, 2020 · 6 comments

Comments

@ngaurav
Copy link
Contributor

ngaurav commented Jan 16, 2020

Most markdown renderers use <br/>\n for newline. Just like flutter_html(1.0), browsers convert \n into space, but they do not render the space when newline is after br tag.

@ngaurav
Copy link
Contributor Author

ngaurav commented Jan 17, 2020

The solution is to change line 414 in html_parser to:
if (tree.text.endsWith(' ') || tree.text.endsWith('\n')) {

@ngaurav
Copy link
Contributor Author

ngaurav commented Feb 21, 2020

@Sub6Resources What are your thoughts on the suggested change?

@ngaurav
Copy link
Contributor Author

ngaurav commented Mar 7, 2020

@Sub6Resources Awaiting your response 🙂

@Sub6Resources
Copy link
Owner

I'm looking into this and your pull request now. Thank you for your patience!

Sub6Resources added a commit that referenced this issue Apr 15, 2020
@Sub6Resources
Copy link
Owner

Merged the PR in. Thank you!

@ngaurav
Copy link
Contributor Author

ngaurav commented Apr 16, 2020

@Sub6Resources My pleasure :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants