Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move HttpRequest.Builder to AllowCallable call function #47

Merged
merged 1 commit into from
Mar 8, 2023
Merged

Move HttpRequest.Builder to AllowCallable call function #47

merged 1 commit into from
Mar 8, 2023

Conversation

xhl1988
Copy link
Contributor

@xhl1988 xhl1988 commented Mar 8, 2023

PR for #46

According to Java doc, HttpRequest.Builder is not thread-safe. So we should construct it in the AllowCallable call() function instead of a static object in object AllowCallable

anderseknert
anderseknert approved these changes Mar 8, 2023
View reviewed changes
Copy link
Member

@anderseknert anderseknert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@anderseknert anderseknert merged commit 0bee48d into StyraInc:main Mar 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@anderseknert anderseknert anderseknert approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@xhl1988 @anderseknert