Added awesome complete support. #302
Conversation
|
Hi @rayrutjes! Sweet thanks! I've gotta run.. if no one gets around to merging this, I'll do it when I get a break later today. |
|
Thanks!
.awesome-autocomplete .aa-descriptioninstead of long selectors like .awesome-autocomplete .tt-dropdown-menu .tt-suggestion .aa-suggestion.aa-repo .aa-description |
|
Also, all instances of It also looks like this definition is a tint of the base color... is there a way we could make it match the base color or use a more neutral color? form#search_form .awesome-autocomplete .twitter-typeahead .tt-input:focus {
border-color: #51A7E8;
} |
|
Ok, working on it, thx |
One could add |
|
Oh, one more thing... I set my base-color to green and noticed these issues:
I would try to help, but whenever the page loses focus, the entire dropdown gets emptied, so it is difficult to figure out class names. |
|
Regarding the border: none, we will have to make an issue on the autocomplete repo I guess. Is a Firefox only issue. |
|
I wonder why it won't show in other browsers. Here is the offending rule. |
|
To be sure to not forget anything:
|
|
Ok, I am good, now waiting for the border fix on AwesomeComplete's side. |
| .awesome-autocomplete .aa-company i, | ||
| .awesome-autocomplete .aa-description, | ||
| .awesome-autocomplete .aa-issue-body{ | ||
| color: #C0C0C0 !important; |
There was a problem hiding this comment.
Could you lowercase the letters in hex colors?
|
I'm curious... the awesome complete dropdown is showing this repo as having 1230 stars, but the star/unstar button at the top of the page is showing 747. Why is there a huge difference? And thanks again for all your hard work! |
|
Oh my, you are so right, I have no idea about that gap, let's ping Algolia ^^. |
|
I opened an issue: algolia/github-awesome-autocomplete#40 |
|
The only missing thing is the delete-icon, but my design skills are limited... There is no white version of the icon, do you have a fallback solution? Could we maybe use one of octotree's icon? |
|
I didn't see a delete icon anywhere, if it is solid black, then you can apply an invert filter: .delete-icon {
-webkit-filter: invert(100%) !important;
filter: invert(100%) !important;
} |
|
There you go! |
| .awesome-autocomplete .tt-suggestion { | ||
| border-color: #343434 !important; | ||
| } | ||
| .awesome-autocomplete .tt-suggestion .octicon { |
There was a problem hiding this comment.
Would you merge this definition with the one above? Everything else looks good to me! Thanks again!
There was a problem hiding this comment.
You mean with the global definitions, those huge lists of classes? 😚
There was a problem hiding this comment.
Oh I get it now, only the octicon?
There was a problem hiding this comment.
He probably means the one on line 2522.
There was a problem hiding this comment.
@silverwind thx, it's done!
| .awesome-autocomplete .aa-thumbnail , | ||
| .awesome-autocomplete .aa-thumbnail { | ||
| background-color: #181818 !important; | ||
| } |
There was a problem hiding this comment.
Is this the user avatar background? If so, I'd make it slightly brighter to it stands out over the background. See the last user here (not sure why it fails to pull his avatar, he has one):
There was a problem hiding this comment.
Oh, and the star should be grey. If it is SVG, you can do fill: currentColor !important on it.
| .awesome-autocomplete .aa-issue-body { | ||
| color: #c0c0c0 !important; | ||
| } | ||
| .awesome-autocomplete .aa-thumbnail , |
|
Not sure about the thumbnail background, your decision. |
|
Well, it would affect any user with transparent backgrounds, which is not GitHub-like. Let's leave it as-is. |
|
Merged in 882b634, thanks! |
Preview:
Fixes #298, algolia/github-awesome-autocomplete#34
Let me know what you think.