Add support for the unicode path extra field #82
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This patch sets the unicode path extra field. unzip needs at least one extra field to correctly handle unicode path, so using the path is as good as any other information. This could improve the situation with other archive managers too. This field is usually used without the utf8 flag, with a non unicode path in the header (winrar, winzip). This helps (a bit) with the messy Windows' default compressed folders feature but breaks on p7zip which doesn't seek the unicode path extra field. So for now, UTF-8 everywhere ! Fix Stuk#79.
dduponchel
added a commit
that referenced
this pull request
Feb 1, 2014
Add support for the unicode path extra field
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch sets the unicode path extra field. unzip needs at least one
extra field to correctly handle unicode path, so using the path is as
good as any other information. This could improve the situation with
other archive managers too.
This field is usually used without the utf8 flag, with a non unicode
path in the header (winrar, winzip). This helps (a bit) with the messy
Windows' default compressed folders feature but breaks on p7zip which
doesn't seek the unicode path extra field.
So for now, UTF-8 everywhere !
Fix #79.