Improve the "unsupported format" error message #461
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The message was misleading and some users misunderstood it: JSZip doesn't reject a file because of what the content actually is (json file, mp4 file, etc). It rejects a file because it is not a supported JavaScript object (usually a plain object containing the buffer, not the buffer directly). The new message and the FAQ entry should help clear the misunderstanding.
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The message was misleading and some users misunderstood it: JSZip doesn't
reject a file because of what the content actually is (json file, mp4
file, etc). It rejects a file because it is not a supported JavaScript
object (usually a plain object containing the buffer, not the buffer
directly).
The new message and the FAQ entry should help clear the
misunderstanding.