Change JSZip.external.Promise implementation. #321
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Importing `es6-promise` had a side effect: this library replaces the global Promise object (Stuk#304) (or tries to, Stuk#309). This is an intended side effect from this library and while its version 4 should give us a switch for this behavior, I don't know when it will be out (the master branch of this project still auto replace the Promise). I replaced it by `vow` which match the requirements: - a Promise implementation - a lightweight one - works in IE6 - doesn't have too many dependencies If a global Promise already exists, prefer it: a native promise is likely to be better integrated anyway (unhandledRejection in node) and some libraries (zone.js for example) replace global objects (Stuk#303). I think it is enough for a semver minor version. Fix Stuk#303 Stuk#304 Stuk#309
Contributor
Author
|
|
The API is closer to the ES6 Promise API and it is smaller than vow. The previous version had a lot of npm dependencies (which is why I prefered `vow`) but the latest version fixed that.
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Importing
es6-promisehad a side effect: this library replaces theglobal Promise object (#304) (or tries to, #309). This is an intended
side effect from this library and while its version 4 should give us a
switch for this behavior, I don't know when it will be out (the master
branch of this project still auto replace the Promise).
I replaced it by
vowwhich match the requirements:If a global Promise already exists, prefer it: a native promise is
likely to be better integrated anyway (unhandledRejection in node) and
some libraries (zone.js for example) replace global objects (#303).
I think it is enough for a semver minor version.
Fix #303 #304 #309