Skip to content

Improve browser testing #269

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
dduponchel merged 5 commits into from
Mar 22, 2016
Merged

Improve browser testing #269

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
5433655
Improve browser testing
evilaliv3 Mar 19, 2016
07f95b1
Fix README style
evilaliv3 Mar 21, 2016
3548729
Fix microsoft EDGE testing with saucelabs
evilaliv3 Mar 21, 2016
b1c738a
Remove duplicated title line in README.markdown
evilaliv3 Mar 21, 2016
0709f07
Add .codeclimate.yml to analyze only lib directory
evilaliv3 Mar 22, 2016
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions .travis.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,8 +2,8 @@ language: node_js
node_js:
- '0.10'
- '0.12'
- '4.0'
- '4.1'
- '4.4'
- 'stable'
script: npm run $COMMAND
sudo: false
env:
Expand Down
50 changes: 41 additions & 9 deletions Gruntfile.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,32 +4,52 @@ module.exports = function(grunt) {
browserName: "iphone",
platform: "OS X 10.8",
version: "6"
}, {
browserName: "iphone",
platform: "OS X 10.10",
version: "9.2"
}, {
browserName: "android",
platform: "Linux",
version: "4.0"
}, {
browserName: "android",
platform: "Linux",
version: "4.4"
}, {
browserName: "android",
platform: "Linux",
version: "5.1"
}, {
browserName: "firefox",
platform: "XP"
platform: "Windows 10"
}, {
browserName: "chrome",
platform: "XP"
platform: "Windows 10"
}, {
browserName: "internet explorer",
platform: "WIN8",
version: "10"
platform: "XP",
version: "7"
}, {
browserName: "internet explorer",
platform: "VISTA",
version: "9"
platform: "Windows 7",
version: "8"
}, {
browserName: "internet explorer",
platform: "Windows 7",
version: "8"
version: "9"
}, {
browserName: "internet explorer",
platform: "XP",
version: "7"
platform: "Windows 8",
version: "10"
}, {
browserName: "internet explorer",
platform: "Windows 10",
version: "11"
}, {
browserName: "edge",
platform: "Windows 10",
version: "13.10586"
}, {
browserName: "opera",
platform: "Windows 2008",
Expand All @@ -38,6 +58,18 @@ module.exports = function(grunt) {
browserName: "safari",
platform: "OS X 10.8",
version: "6"
}, {
browserName: "safari",
platform: "OS X 10.9",
version: "7"
}, {
browserName: "safari",
platform: "OS X 10.10",
version: "8"
}, {
browserName: "safari",
platform: "OS X 10.11",
version: "9"
}];

var tags = [];
Expand Down
13 changes: 4 additions & 9 deletions README.markdown
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,7 @@
JSZip
JSZip [![Build Status](https://api.travis-ci.org/Stuk/jszip.svg?branch=master)](http://travis-ci.org/Stuk/jszip) [![Code Climate](https://codeclimate.com/github/Stuk/jszip/badges/gpa.svg)](https://codeclimate.com/github/Stuk/jszip)
Copy link
Contributor

@dduponchel dduponchel Mar 20, 2016

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Putting the images here break the title. Any reason to move the build status ?
Also, I wouldn't put the codeclimate badge: the final score makes little sense as it currently includes generated files.

Copy link
Contributor Author

@evilaliv3 evilaliv3 Mar 20, 2016

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

let's remove the generated files :)

https://docs.codeclimate.com/docs/excluding-files-and-folders


[![Selenium Test Status](https://saucelabs.com/browser-matrix/jszip.svg)](https://saucelabs.com/u/jszip)

=====
Copy link
Contributor

@dduponchel dduponchel Mar 21, 2016

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This line was here to format "JSZip" as a title but since you added an other one above, you should remove it (it generates an empty title line, see here).

Copy link
Contributor Author

@evilaliv3 evilaliv3 Mar 21, 2016

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

k!


A library for creating, reading and editing .zip files with Javascript, with a
Expand Down Expand Up @@ -26,14 +29,6 @@ images/
smile.gif
*/
```

Test status
-----------

[![Build Status](https://api.travis-ci.org/Stuk/jszip.svg?branch=master)](http://travis-ci.org/Stuk/jszip)

[![Selenium Test Status](https://saucelabs.com/browser-matrix/jszip.svg)](https://saucelabs.com/u/jszip)

License
-------

Expand Down