Open start page automatically when starting lobby #34
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
l0f3n
force-pushed
the
open-first-page-on-start
branch
from
60a23bd to
e068527
Compare
sornas
reviewed
Jan 15, 2025
l0f3n
force-pushed
the
open-first-page-on-start
branch
from
0f901f7 to
c2ab453
Compare
sornas
reviewed
Jan 17, 2025
|
i'd like to test this out too, probably tomorrow |
l0f3n
force-pushed
the
open-first-page-on-start
branch
4 times, most recently
from
7d91e08 to
eec41f1
Compare
|
Also added the open first article button, so fixes #9. Very basic. |
This was
linked to
issues
Jan 17, 2025
sornas
approved these changes
Jan 17, 2025
|
actually, maybe "open start page" could read "open first page" because start page could just as well refer to the wikiweaver start page (even though we don't really have one) |
Use server-sent events to automatically open the start page when the host starts the lobby. Since they are one-sided, keep them alive as long the lobby is alive. If an extension joins a different lobby, it automatically closes its current eventstream (which the server wont know about) and wont receive any updates from the old lobby. Signed-off-by: Victor Löfgren <[email protected]>
Signed-off-by: Victor Löfgren <[email protected]>
Signed-off-by: Victor Löfgren <[email protected]>
l0f3n
force-pushed
the
open-first-page-on-start
branch
from
eec41f1 to
84befb2
Compare
Signed-off-by: Victor Löfgren <[email protected]>
Signed-off-by: Victor Löfgren <[email protected]>
l0f3n
force-pushed
the
open-first-page-on-start
branch
from
84befb2 to
d811a95
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Solves #11
Use server-sent events to automatically open the start page when the host starts the lobby. Since they are one-sided, keep them alive as long the lobby is alive. If an extension joins a different lobby, it automatically closes its current eventstream (which the server wont know about) and wont receive any updates from the old lobby.