Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow defining multiple announce urls for one tracker #328

Merged
merged 4 commits into from
Jun 11, 2023

Conversation

buthed010203
Copy link
Contributor

Description

Previously, if a tracker had two announce URLs hello.world and foo.bar, the tracker block would look something like

tracker:
  hello.world:
    tag: sometag
  foo.bar:
    tag: sometag

Obviously this isn't ideal, this PR allows for pipes in tracker definitions so that the example above would become

tracker:
  hello.world|foo.bar:
    tag: sometag

While this isn't as much of an issue now that share ratios are handled in a different block, this condensed format should make it easier to keep track of a large number of trackers (no pun intended).

I am unsure as to where this should be documented so I have not done so for now

Type of change

  • New feature (non-breaking change which adds functionality)
  • This change requires a documentation update

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have added or updated the docstring for new or existing methods
  • I have modified this PR to merge to the develop branch

@bobokun bobokun merged commit 1169ef3 into StuffAnThings:develop Jun 11, 2023
@bobokun bobokun mentioned this pull request Jun 16, 2023
@buthed010203 buthed010203 deleted the patch-1 branch January 20, 2024 17:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants