Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix crash in cross-seed module #290

Merged
merged 2 commits into from
May 18, 2023
Merged

Fix crash in cross-seed module #290

merged 2 commits into from
May 18, 2023

Conversation

buthed010203
Copy link
Contributor

Description

The code was referencing a variable that would never be assigned on that branch, it was likely a typo as there is a similar variable that is assigned. I have swapped it to use the similarly named variable.

Fixes #287

Type of change

Bug fix (non-breaking change which fixes an issue)

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have added or updated the docstring for new or existing methods
  • I have added tests when applicable

@buthed010203 buthed010203 changed the base branch from master to develop May 18, 2023 18:45
@bobokun bobokun merged commit 8c697b7 into StuffAnThings:develop May 18, 2023
@buthed010203 buthed010203 deleted the patch-2 branch May 18, 2023 19:17
@bobokun bobokun mentioned this pull request May 24, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bobokun bobokun bobokun approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Bug]: Cross seed module is throwing an exception due to a missing variable
2 participants
@buthed010203 @bobokun