Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[FR]: Logging header doesn't get logged for every run #591

Closed
jonoff opened this issue Jun 22, 2024 · 0 comments · Fixed by #602
Closed

[FR]: Logging header doesn't get logged for every run #591

jonoff opened this issue Jun 22, 2024 · 0 comments · Fixed by #602
Assignees
@bobokun
Labels
feature request New feature or request status:added-to-develop Feature Request or Bug Fix is in Develop

Comments

@jonoff
Copy link

jonoff commented Jun 22, 2024

Describe the Bug

The logging header, which contains useful version information is only printed once per container start as it is not inside the start() function. https://github.com/StuffAnThings/qbit_manage/blob/master/qbit_manage.py#L634 is the line in question, and would be useful to have in every run.

Config

No response

Logs

n/a

Screenshots

No response

Installation

Docker

Version Number

should be easier to find :)

What branch are you on?

master
@jonoff jonoff added the bug Something isn't working label Jun 22, 2024
@bakerboy448 bakerboy448 added feature request New feature or request and removed bug Something isn't working labels Jun 27, 2024
@bakerboy448 bakerboy448 changed the title [Bug]: Logging header doesn't get logged for every run [FR]: Logging header doesn't get logged for every run Jun 27, 2024
bobokun added a commit that referenced this issue Jun 30, 2024
@bobokun
Fixes #591 [FR]: Logging header doesn't get logged for every run
5ee9331
@bobokun bobokun added the status:added-to-develop Feature Request or Bug Fix is in Develop label Jun 30, 2024
bobokun added a commit that referenced this issue Jun 30, 2024
@bobokun
minor fixes in #591
adb58dd
@bobokun bobokun mentioned this issue Jul 5, 2024
Merged
@bobokun bobokun closed this as completed in 4e08f62 Jul 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@bobokun bobokun

Labels
feature request New feature or request status:added-to-develop Feature Request or Bug Fix is in Develop
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

4.1.7 StuffAnThings/qbit_manage
3 participants
@jonoff @bobokun @bakerboy448