Attempting noHL Cleanup on develop

[undaunt]

Hello,

I'm attempting to delete non-HL files after a minimum seed time of 30 days, such as in the case Radarr replaces a movie and I've met the minimum tracker enforce seed times.

It's not letting me set the max seed time as lower than the min seed time, nor the max ratio as 0. Basically I'm trying to let the files seed for as long as possible until such time they are safe to be deleted, so I don't want to set a max ratio.

On the new develop version I'm getting warnings such as the following during test:

Config Error: min_seeding_time (43200) is greater than max_seeding_time (-1) for the grouping 'noHL-movies'. | 2024-04-01T22:10:13.837737623Z | min_seeding_time must be less than or equal to max_seeding_time.
Config Error: min_seeding_time (43200) is set, but max_ratio (-1) is not set for the grouping 'noHL-movies'. | 2024-04-01T22:10:36.836036015Z | max_ratio must be greater than 0 when min_seeding_time is set.
Config Error: min_seeding_time (43200) is set, but max_ratio (0.0) is not set for the grouping 'noHL-movies'. | 2024-04-01T22:11:00.358253334Z | max_ratio must be greater than 0 when min_seeding_time is set.

What is the recommended approach? Config below. Yes, I have dry-run on for testing. Thank you.

commands:
  dry_run: true
  cross_seed: false
  recheck: false
  cat_update: true
  tag_update: true
  rem_unregistered: true
  tag_tracker_error: true
  rem_orphaned: true
  tag_nohardlinks: true
  share_limits: true
  skip_cleanup: false
  skip_qb_version_check: false

qbt:
  host: gluetun-movies:8081
  user:
  pass:

settings:
  force_auto_tmm: true
  tracker_error_tag: issue
  nohardlinks_tag: noHL
  share_limits_tag: ~share_limit
  share_limits_min_seeding_time_tag: MinSeedTimeNotReached
  share_limits_min_num_seeds_tag: MinSeedsNotMet
  share_limits_last_active_tag: LastActiveLimitNotReached
  ignoreTags_OnUpdate:
  # Core tags
  - issue
  - noHL
  - cross-seed
  - MinSeedTimeNotReached
  - MinSeedsNotMet
  - LastActiveLimitNotReached
  # Custom tags
  - upload
  - source
  - seadex
  - multipart
  - edition
  - cut
  # Content type
  - anime
  - comedy
  - film
  - sports
  cross_seed_tag: cross-seed
  cat_filter_completed: true
  share_limits_filter_completed: true
  tag_nohardlinks_filter_completed: true
  force_retag_all: false

directory:
  cross_seed: /downloads/watched/
  root_dir: /downloads/data/
  recycle_bin: /downloads/recycled/
  torrents_dir: /torrents/
  orphaned_dir: /downloads/orphaned/
  remote_dir: /downloads/data/

nohardlinks:
- Imported - Anime
- Imported - Movies:
    exclude_tags:
    - upload
    - source
- Seed - Anime
- Seed - Movies:
    exclude_tags:
    - upload
    - source

share_limits:
  noHL-movies:
    priority: 1
    include_all_tags: noHL
    exclude_any_tags:
    - upload
    - source
    categories:
    - Imported - Movies
    - Seed - Movies
    max_ratio: 0
    max_seeding_time: 43200
    min_seeding_time: 43200 # 30 days
    cleanup: true

[bobokun]

In your case you can remove the line max_ratio: 0 and also the min_seeding_time: 43200 # 30 days and only have max_seeding_time defined.

[undaunt]

Perfect, understood, thanks!

[bakerboy448]

Docs should cover this as well

https://github.com/StuffAnThings/qbit_manage/wiki/Config-Setup#share_limits

min_seeding_time

Will prevent torrent deletion by cleanup variable if torrent has not yet met minimum seeding time (minutes) even if maximum seeding ratio is met. If the torrent has not yet reached this minimum seeding time, it will change the share limits back to no limits and resume the torrent to continue seeding. Mandatory that max_seeding_time is greater than or equal to min_seeding_time. Mandatory that max_ratio is configured and greater than 0.

[undaunt]

I think that is why I was using min_seeding_time as it implies protecting the torrent from cleanup even if max ratio has been met. The fact that I am able to get a similar behavior out of max_seeding_time when attempting to clean up is nice, but confusing based on the naming convention. I would expect that if I wanted to seed something forever, until such time that it is not hardlinked (or whatever other criteria I set within tagging) that I would only need to set a minimum, not a maximum.

I envision scenarios where maximum is helpful for stopping seeding without cleaning after a set period of time. I'm glad the issue is resolved, but it seems confusing.

[bakerboy448]

Specific PRs to the language in the docs or config file welcome. Generic complaints about confusion without specific fixes are not

nothing anywhere says or implies min seed time and max seed time do the same thing

[undaunt]

I wasn't complaining, and your attitude doesn't engender a desire to submit a PR. The wording of "minimum seed time" and "maximum seed time" are not what I equivocated as doing the same thing. The fact that I need to set only a "maximum" when in fact I am trying to enforce a "minimum" duration of seeding before a cleanup is what is confusing.