Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Include full date/time for log entries #596

Merged
merged 2 commits into from
Jun 15, 2014

Conversation

VBelozyorov
Copy link
Contributor

I think for the time stamp in the context of the logs 24-hour time format is more common, rather than 12-hour. What do you think about this?

@stennie
Copy link
Contributor

stennie commented Jun 15, 2014

@VBelozyorov AM/PM versus 24-hour format is probably personal preference, but if using 24-hour format I would also change to hh (leading 0 for the hour).

However, I think it be would be even better to use the ISO8601 format for logs (eg yyyy-mm-dd hh:mm:ss). A full datestamp would be useful when copying entries from the log window, and in the case where a Robomongo session has been open for more than a day and the times start to wrap around.

@stennie stennie changed the title AM/PM removed from records in LogWidget Include full date/time for log entries Jun 15, 2014
@stennie
Copy link
Contributor

stennie commented Jun 15, 2014

@VBelozyorov Thanks for updating, merged!

stennie added a commit that referenced this pull request Jun 15, 2014
Include full date/time for log entries
@stennie stennie merged commit 137b859 into Studio3T:master Jun 15, 2014
@stennie stennie added this to the Robomongo 0.8.5 milestone Jun 15, 2014
@VBelozyorov VBelozyorov deleted the logs-time-format branch June 16, 2014 11:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants