Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Expand/collapse multiple selections #591

Merged
merged 7 commits into from
Jun 17, 2014
Merged

Conversation

VBelozyorov
Copy link
Contributor

PR for issue #384

Have to little bit change one method of Notifier, I've found two usages of it and seems nothing broke :)

@stennie
Copy link
Contributor

stennie commented Jun 16, 2014

@VBelozyorov The general functionality of expanding/collapsing documents works, but there are two issues to look into:

  1. There seems to be an obvious bug where Notifier::initMultiSelectionMenu() is replacing the default context menu of Notifier::initMenu(). For example, try selecting an ObjectId(); the context menu should include _copyValueAction and _copyTimestampAction.

  2. To set expectations properly, I think the context menu items should be "Expand Document Recursively" and "Collapse Document Recursively". My initial (incorrect) expectation was the recursive expand/collapse might also expand or collapse the selected subtree of a document.

Thanks!

@VBelozyorov
Copy link
Contributor Author

@stennie One small issue is still remains: if you select several fields inside one document, then expand / collapse will work only for the field which has been selected first.
The reason of such behaviour in implementation of BsonTreeView::selectedIndex().
For example, same goes if you select _id and some another field in the document: in context menu will be copy timestamp ... item which is specific for fields with ObjectId type.

@stennie
Copy link
Contributor

stennie commented Jun 17, 2014

@VBelozyorov Think can live with that small issue, but feel free to submit a separate PR for it.

Thanks for fixing up support for subdocuments .. very handy!

@stennie stennie added this to the Robomongo 0.8.5 milestone Jun 17, 2014
@stennie stennie changed the title Expand/collapse multiple documents Expand/collapse multiple selections Jun 17, 2014
stennie added a commit that referenced this pull request Jun 17, 2014
Expand/collapse multiple selections
@stennie stennie merged commit 0158175 into Studio3T:master Jun 17, 2014
@VBelozyorov VBelozyorov deleted the issue-384 branch June 17, 2014 07:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants