Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Restore plugin compatibility with Gradle 8.12+ #203

Merged
merged 1 commit into from
Jan 17, 2025

Conversation

lppedd
Copy link
Contributor

@lppedd lppedd commented Jan 16, 2025

Fixes #201
Supersedes #202

cc @Komdosh

Manually tested with Gradle 8.8 and 8.12
@Komdosh
Copy link

Komdosh commented Jan 16, 2025

Actually, you have to wrap it in a try-catch. It will throw a NoSuchMethodException if method redirectErrorStream not exists.

@lppedd
Copy link
Contributor Author

lppedd commented Jan 16, 2025

@Komdosh but AFAIK that method always exists, that's why I didn't wrap it.

What changed over time is the class hierarchy and thus the bytecode-level compatibility.

@Komdosh
Copy link

Komdosh commented Jan 16, 2025

Hmm, I thought that problem was in the removed method redirectErrorStream of the deprecated and removed class AbstractExecHandleBuilder, but it was moved to JavaExecHandleBuilder. Okay, that makes sense.

@ftomassetti
Copy link
Member

Thank you!

@ftomassetti ftomassetti merged commit 07b6eae into Strumenta:master Jan 17, 2025
6 checks passed
@lppedd lppedd deleted the fix/gradle-compat branch January 17, 2025 15:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

AntlrKotlinTask is not compatible with Gradle 8.12
3 participants