Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Avoid NPE when dealing with visitors #183

Merged
merged 3 commits into from
Jun 12, 2024

Conversation

lppedd
Copy link
Contributor

@lppedd lppedd commented Jun 11, 2024

This is the idea in practice.

Fixes #182

@lppedd lppedd force-pushed the fix/nullability branch from 801e3de to c56c303 Compare June 11, 2024 00:12
@lppedd lppedd force-pushed the fix/nullability branch from c56c303 to d27dc1b Compare June 11, 2024 00:31
@lppedd lppedd marked this pull request as ready for review June 11, 2024 12:58
@lppedd
Copy link
Contributor Author

lppedd commented Jun 11, 2024

@ftomassetti I don't have better ideas, and this looks like it's good enough, so I marked the PR as reviewable.

@ftomassetti
Copy link
Member

I also do not have better ideas and I did not use visitors in many years. The only comment I can make is that a test for this specific use case would be a nice to have, but I would not consider a requirement for merging this. If I do not hear from you I will just go ahead and merge it on Friday

@lppedd
Copy link
Contributor Author

lppedd commented Jun 12, 2024

@ftomassetti added a very simple test case, I think it's sufficient to establish if everything works well together.

Next would be RC4? If everything is ok after a couple weeks, you could release 1.0.0. No point in waiting more time.

@ftomassetti
Copy link
Member

Thank you @lppedd

Next would be RC4? If everything is ok after a couple weeks, you could release 1.0.0. No point in waiting more time.

Yes and yes

@ftomassetti ftomassetti merged commit 4478f94 into Strumenta:master Jun 12, 2024
6 checks passed
@lppedd lppedd deleted the fix/nullability branch June 12, 2024 10:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Generated BaseVisitor does not handle nullable types
2 participants