(B) QTY-14939 Fix hammering attendance API #491
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
For schools that do not use attendance lockouts, we are currently hitting the attendance API and getting a 404, triggering an exception to sentry and causing attendance API to do way more work than it should. Fix this by checking for an env var ( ATTENDANCE_LOCKOUT_ENABLED ). Co-authored-by: Tyler Rhodes <[email protected]>
Co-authored-by: Tyler Rhodes <[email protected]>
There was a problem hiding this comment.
Pull Request Overview
This PR fixes the hammering of the attendance API for environments where attendance lockouts are disabled by checking for the ATTENDANCE_LOCKOUT_DISABLED environment variable.
- Updated test cases to validate behavior when the environment variable is set or not set.
- Refactored the locked_out? method in the attendance service to return false early when the environment variable is present and rearranged helper methods.
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| spec/services/attendance_service/commands/check_lockout_spec.rb | Added contexts and updated tests for handling attendance lockout based on the environment variable |
| app/services/attendance_service/commands/check_lockout.rb | Modified locked_out? method and reorganized helper methods for clarity |
tylerCaineRhodes
approved these changes
Mar 13, 2025
Because of a missing after do to clean up env, we were inconsistently failing. Also, we don't need a user check is we have a pseudonym, so remove that extra call (both complexity and performance). Co-authored-by: Mike Benner <[email protected]>
Co-authored-by: Mike Benner <[email protected]>
refriedchicken
approved these changes
Mar 14, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Link to Jira ticket
Purpose
For schools that do not use attendance lockouts, we are currently hitting the attendance API and getting a 404, triggering an exception to sentry and causing attendance API to do way more work than it should.
Approach
Fix this by checking for an env var ( ATTENDANCE_LOCKOUT_DISABLED ).
Testing
Manual testing + unit testing