Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: Rework public API #517

Merged
merged 1 commit into from
Sep 18, 2024
Merged

refactor: Rework public API #517

merged 1 commit into from
Sep 18, 2024

Conversation

Stranger6667
Copy link
Owner

@Stranger6667 Stranger6667 commented Sep 18, 2024

Resolves #424

Signed-off-by: Dmitry Dygalo <[email protected]>
Copy link

codspeed-hq bot commented Sep 18, 2024

CodSpeed Performance Report

Merging #517 will degrade performances by 13.17%

Comparing dd/more-renaming (ccd31c9) with master (3e83197)

Summary

❌ 1 (👁 1) regressions
✅ 11 untouched benchmarks

🆕 5 new benchmarks
⁉️ 5 (👁 5) dropped benchmarks

Benchmarks breakdown

Benchmark master dd/more-renaming Change
🆕 CITM/build N/A 658.1 µs N/A
👁 CITM/compile 655 µs N/A N/A
👁 Fast/Invalid[is_valid] 769.4 ns 886.1 ns -13.17%
🆕 Fast/build N/A 217.6 µs N/A
👁 Fast/compile 214.9 µs N/A N/A
🆕 GeoJSON/build N/A 1.8 ms N/A
👁 GeoJSON/compile 1.8 ms N/A N/A
🆕 Open API/build N/A 4.6 ms N/A
👁 Open API/compile 4.6 ms N/A N/A
🆕 Swagger/build N/A 4.8 ms N/A
👁 Swagger/compile 4.6 ms N/A N/A

Copy link

codecov bot commented Sep 18, 2024

Codecov Report

Attention: Patch coverage is 68.01347% with 95 lines in your changes missing coverage. Please review.

Project coverage is 85.01%. Comparing base (3e83197) to head (ccd31c9).
Report is 1 commits behind head on master.

Files with missing lines Patch % Lines
crates/jsonschema/src/error.rs 82.00% 18 Missing ⚠️
crates/jsonschema-py/src/lib.rs 0.00% 16 Missing ⚠️
crates/jsonschema/src/compilation/mod.rs 66.66% 6 Missing ⚠️
crates/jsonschema/src/compilation/options.rs 76.19% 5 Missing ⚠️
crates/jsonschema/src/keywords/dependencies.rs 0.00% 5 Missing ⚠️
crates/jsonschema/src/keywords/helpers.rs 0.00% 5 Missing ⚠️
...tes/jsonschema/src/keywords/legacy/type_draft_4.rs 42.85% 4 Missing ⚠️
crates/jsonschema/src/keywords/type_.rs 69.23% 4 Missing ⚠️
crates/jsonschema/src/keywords/content.rs 50.00% 3 Missing ⚠️
...ates/jsonschema/src/keywords/pattern_properties.rs 0.00% 3 Missing ⚠️
... and 21 more
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #517      +/-   ##
==========================================
- Coverage   85.09%   85.01%   -0.09%     
==========================================
  Files          69       69              
  Lines       10566    10568       +2     
==========================================
- Hits         8991     8984       -7     
- Misses       1575     1584       +9     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Stranger6667 Stranger6667 merged commit 74354df into master Sep 18, 2024
30 checks passed
@Stranger6667 Stranger6667 deleted the dd/more-renaming branch September 18, 2024 17:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

JSONSchema and JSONPointer don’t follow naming conventions
1 participant