Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

JSONSchema and JSONPointer don’t follow naming conventions #424

Closed
SabrinaJewson opened this issue Apr 4, 2023 · 1 comment · Fixed by #517
Closed

JSONSchema and JSONPointer don’t follow naming conventions #424

SabrinaJewson opened this issue Apr 4, 2023 · 1 comment · Fixed by #517

Comments

@SabrinaJewson
Copy link

See C-CASE:

In UpperCamelCase, acronyms and contractions of compound words count as one word: use Uuid rather than UUID, Usize rather than USize or Stdin rather than StdIn

These types should be named JsonSchema and JsonPointer.

(this is quite low-priority but you might want to fix it before 1.0)

@Stranger6667
Copy link
Owner

Thank you for opening this issue! I was thinking about it and the main concern was the name clash with ‘schemars’, so I put all the renaming things aside. However, I’d like to address it before 1.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants