Make filepath separator OS-independent #91
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ts checks This change fixes an issue with inclusion and exclusion lists not being taken into account correctly for directories on Windows machines due to a hard-coded separator character.
iuliaturc
reviewed
Oct 22, 2024
| @@ -159,7 +159,7 @@ def _should_include(self, file_path: str) -> bool: | |||
| _, extension = os.path.splitext(file_path) | |||
| extension = extension.lower() | |||
| file_name = os.path.basename(file_path) | |||
| dirs = os.path.dirname(file_path).split("/") | |||
| dirs = os.path.dirname(file_path).split(os.sep) | |||
There was a problem hiding this comment.
That's a very good idea. For consistency, would you mind making this update in other places in the codebase?
grep -nr '.split("/")' sage
sage/sage/retriever.py:244: items = path.split("/")
sage/sage/retriever.py:256: root_path = "/" + repo_metadata[0]["file_path"].split("/")[0]
sage/sage/retriever.py:278: org_name, repo_name = repo_id.split("/") <--- this one shouldn't be updated
sage/sage/retriever.py:279: items = filename.split("/")
sage/sage/data_manager.py:166: dirs = os.path.dirname(file_path).split("/")
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
This PR fixes an issue with inclusion and exclusion lists not being taken into account correctly for directories on Windows machines due to a hard-coded separator character.
Replaced the hard-coded
"/"with aos.septo make the filepath separator OS-independent.