Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add tqdm and trange imports for progress tracking when indexing #59 #68

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

Suvendu-UI
Copy link

What does this PR do?

it solves the issue of progress bar while indexing

Fixes # 59

Before submitting

  • This PR fixes a typo or improves the docs (you can dismiss the other checks if that's the case).
  • Was this discussed/approved via a Github issue? Please add a link
    to it if that's the case.
  • Did you make sure to update the documentation with your changes?
  • Did you write any new necessary tests?

Who can review?

Anyone in the community is free to review the PR once the tests have passed. Feel free to tag members/contributors who
may be interested in your PR.

@Suvendu-UI Suvendu-UI changed the title Add tqdm and trange imports for progress tracking when indexing Add tqdm and trange imports for progress tracking when indexing #59 Oct 8, 2024
Copy link
Contributor

@iuliaturc iuliaturc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @Suvendu-UI, thanks for your PR! I'm trying to run this but I'm seeing some some syntax errors:

File "my-venv/bin/sage-index", line 5, in <module>
    from sage.index import main
  File "sage/sage/index.py", line 12, in <module>
    from sage.embedder import build_batch_embedder_from_flags
  File "sage/sage/embedder.py", line 397
    for chunk, embedding in tqdm(zip(batch, result["embedding"]):)
                                                                ^
SyntaxError: invalid syntax

Could you please address them? Here's the command I used (you'll need to have a pinecone account):

sage-index iuliaturc/detextify --mode=remote --pinecone-index-name=your-pinecone-index

@Suvendu-UI
Copy link
Author

this error is showing due to a hit in the billing hard limit in my free account

@iuliaturc
Copy link
Contributor

@Suvendu-UI it actually looks like a syntax error, I believe the semicolon should be after the closed paranthesis.

@iuliaturc
Copy link
Contributor

@Suvendu-UI Just checking in: are you still working on this issue or should I take over?

@Suvendu-UI
Copy link
Author

I am very sorry pls take it over

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants