-
Notifications
You must be signed in to change notification settings - Fork 1
V2.0.0 #16
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Caution Review failedThe pull request is closed. WalkthroughRefactors CLI and core service startup, adds async launch/control APIs, introduces custom endpoints loading, parent-process watching, and service launcher internals. Updates README and tests accordingly. Adjusts packaging/dependencies and ignores. Renames internal helpers in the main controller. Bumps version to 2.0.0 and reworks metadata/config files. Changes
Sequence Diagram(s)sequenceDiagram
autonumber
actor User as CLI User
participant CLI as Команда "run"
participant Watcher as КонтроллерРодительскогоПроцесса
participant Launcher as ЗапускательСервиса
participant Server as Веб-сервер
User->>CLI: oscript app.os run --host --port [--parent-pid PID] [--routes-handlers ...]
alt PID provided
CLI->>Watcher: НачатьНаблюдение(PID)
Note right of Watcher: Periodically checks parent process
end
CLI->>Launcher: Запустить(Хост, Порт)
Launcher->>Server: Настроить и запустить
Watcher-->>CLI: (async monitoring)
Server-->>User: Сервис принимает запросы
sequenceDiagram
autonumber
actor Test as Tests
participant HB as HttpBin
participant OS as OScript Runtime
participant Svc as Сервис (external process)
participant Probe as HTTP Probe
Test->>HB: УстановитьХост/Порт/РасположениеКонтроллеров
Test->>HB: Запустить() / ЗапуститьАсинх()
HB->>OS: ЗапуститьПроцесс(Синхронно/Асинхронно)
OS->>Svc: Spawn with args [--routes-handlers ...]
opt Синхронно
HB->>Probe: НачатьОжиданиеЗапуска → HEAD URL
Probe-->>HB: 200/готов
end
Test->>HB: URL("/path")
Test->>Svc: HTTP запросы
Test->>HB: ОжидатьЗавершения() / Активен() / Отвечает()
Estimated code review effort🎯 4 (Complex) | ⏱️ ~60 minutes Possibly related PRs
Poem
✨ Finishing touches🧪 Generate unit tests (beta)
📜 Recent review detailsConfiguration used: CodeRabbit UI Review profile: CHILL Plan: Pro 📒 Files selected for processing (18)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Summary by CodeRabbit
New Features
Documentation
Chores