Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Show the user roles as real names #867

Merged
merged 6 commits into from
Mar 6, 2024
Merged

Show the user roles as real names #867

merged 6 commits into from
Mar 6, 2024

Conversation

Ludy87
Copy link
Contributor

@Ludy87 Ludy87 commented Mar 5, 2024

Description

Show the user roles as real names

Closes #864

Checklist:

  • I have read the Contribution Guidelines
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • My changes generate no new warnings

Contributor License Agreement

By submitting this pull request, I acknowledge and agree that my contributions will be included in Stirling-PDF and that they can be relicensed in the future under the MPL 2.0 (Mozilla Public License Version 2.0) license.

(This does not change the general open-source nature of Stirling-PDF, simply moving from one license to another license)

@Ludy87 Ludy87 requested a review from Frooodle as a code owner March 5, 2024 11:24
Copy link

gitguardian bot commented Mar 5, 2024

⚠️ GitGuardian has uncovered 6 secrets following the scan of your pull request.

Please consider investigating the findings and remediating the incidents. Failure to do so may lead to compromising the associated services or software components.

🔎 Detected hardcoded secrets in your pull request
GitGuardian id GitGuardian status Secret Commit Filename
- Username Password 2f01437 src/main/resources/messages_tr_TR.properties View secret
- Username Password febad34 src/main/resources/messages_tr_TR.properties View secret
- Username Password febad34 src/main/resources/messages_sr_LATN_RS.properties View secret
- Username Password 2f01437 src/main/resources/messages_sr_LATN_RS.properties View secret
- Username Password febad34 src/main/resources/messages_nl_NL.properties View secret
- Username Password 2f01437 src/main/resources/messages_nl_NL.properties View secret
🛠 Guidelines to remediate hardcoded secrets
  1. Understand the implications of revoking this secret by investigating where it is used in your code.
  2. Replace and store your secrets safely. Learn here the best practices.
  3. Revoke and rotate these secrets.
  4. If possible, rewrite git history. Rewriting git history is not a trivial act. You might completely break other contributing developers' workflow and you risk accidentally deleting legitimate data.

To avoid such incidents in the future consider


🦉 GitGuardian detects secrets in your source code to help developers and security teams secure the modern development process. You are seeing this because you or someone else with access to this repository has authorized GitGuardian to scan your pull request.

Our GitHub checks need improvements? Share your feedbacks!

@Frooodle
Copy link
Member

Frooodle commented Mar 5, 2024

⚠️ GitGuardian has uncovered 6 secrets following the scan of your pull request.

Please consider investigating the findings and remediating the incidents. Failure to do so may lead to compromising the associated services or software components.

🔎 Detected hardcoded secrets in your pull request
GitGuardian id GitGuardian status Secret Commit Filename
- Username Password 2f01437 src/main/resources/messages_tr_TR.properties View secret
- Username Password febad34 src/main/resources/messages_tr_TR.properties View secret
- Username Password febad34 src/main/resources/messages_sr_LATN_RS.properties View secret
- Username Password 2f01437 src/main/resources/messages_sr_LATN_RS.properties View secret
- Username Password febad34 src/main/resources/messages_nl_NL.properties View secret
- Username Password 2f01437 src/main/resources/messages_nl_NL.properties View secret
🛠 Guidelines to remediate hardcoded secrets
  1. Understand the implications of revoking this secret by investigating where it is used in your code.
  2. Replace and store your secrets safely. Learn here the best practices.
  3. Revoke and rotate these secrets.
  4. If possible, rewrite git history. Rewriting git history is not a trivial act. You might completely break other contributing developers' workflow and you risk accidentally deleting legitimate data.

To avoid such incidents in the future consider


🦉 GitGuardian detects secrets in your source code to help developers and security teams secure the modern development process. You are seeing this because you or someone else with access to this repository has authorized GitGuardian to scan your pull request.

Our GitHub checks need improvements? Share your feedbacks!

Time to remove this 😂

@Frooodle
Copy link
Member

Frooodle commented Mar 5, 2024

Was a trial and it failed :')

@Frooodle Frooodle merged commit 9747231 into Stirling-Tools:main Mar 6, 2024
3 of 4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Feature] Show the user roles as real names.
2 participants