Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove file input append #2497

Merged
merged 2 commits into from
Dec 18, 2024
Merged

Conversation

reecebrowne
Copy link
Contributor

@reecebrowne reecebrowne commented Dec 18, 2024

Description

The issue that this logic handles is now handled elsewhere, this causes bugs of its own. Can be removed entirely

Closes #(2487)

Checklist

  • [ X] I have read the Contribution Guidelines
  • [ X] I have performed a self-review of my own code
  • [ X] I have attached images of the change if it is UI based
  • [ X] I have commented my code, particularly in hard-to-understand areas
  • [X ] If my code has heavily changed functionality I have updated relevant docs on Stirling-PDFs doc repo
  • [ X] My changes generate no new warnings
  • [ X] I have read the section Add New Translation Tags (for new translation tags only)

@dosubot dosubot bot added the size:XS This PR changes 0-9 lines, ignoring generated files. label Dec 18, 2024
@github-actions github-actions bot added the Front End Issues or pull requests related to front-end development label Dec 18, 2024
@dosubot dosubot bot added the Bug Something isn't working label Dec 18, 2024
@Frooodle Frooodle merged commit 1862ab1 into Stirling-Tools:main Dec 18, 2024
11 of 12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Something isn't working Front End Issues or pull requests related to front-end development size:XS This PR changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants