Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: form data not being sent in multi #2492

Merged

Conversation

omar-ahmed42
Copy link
Contributor

Description

Problem:

  • When a form is submitted and multi downloads is expected, the file is sent successfully but not the form data/body as let postForm = document.querySelector('form[method="POST"]'); retrieves the first form found and it's mostly the CSRF form

Solution:

  • Pass form to submitMultiPdfForm to use in FormData creation.

Closes #2490, #2488

Checklist

  • I have read the Contribution Guidelines
  • I have performed a self-review of my own code
  • I have attached images of the change if it is UI based
  • I have commented my code, particularly in hard-to-understand areas
  • If my code has heavily changed functionality I have updated relevant docs on Stirling-PDFs doc repo
  • My changes generate no new warnings
  • I have read the section Add New Translation Tags (for new translation tags only)

- Pass form to submitMultiPdfForm to use in FormData creation.
@dosubot dosubot bot added size:XS This PR changes 0-9 lines, ignoring generated files. Bug Something isn't working labels Dec 17, 2024
@github-actions github-actions bot added the Front End Issues or pull requests related to front-end development label Dec 17, 2024
@Frooodle Frooodle merged commit b0daac2 into Stirling-Tools:main Dec 18, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Something isn't working Front End Issues or pull requests related to front-end development size:XS This PR changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: Image to pdf java.lang.NullPointerException
2 participants