Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix: Rename LANGS variable in init.sh to avoid clashing with LANGS env #2468

Merged
merged 1 commit into from
Dec 16, 2024
Merged

Fix: Rename LANGS variable in init.sh to avoid clashing with LANGS env #2468

merged 1 commit into from
Dec 16, 2024

Conversation

omar-ahmed42
Copy link
Contributor

Description

Rename LANGS variable in init.sh for TESSERACT_LANGS languages as it conflicts with the variable LANGS that is responsible for installing fonts

Closes #2464

Checklist

  • I have read the Contribution Guidelines
  • I have performed a self-review of my own code
  • I have attached images of the change if it is UI based
  • I have commented my code, particularly in hard-to-understand areas
  • If my code has heavily changed functionality I have updated relevant docs on Stirling-PDFs doc repo
  • My changes generate no new warnings
  • I have read the section Add New Translation Tags (for new translation tags only)

@omar-ahmed42
Rename LANGS variable in init.sh to avoid overriding font LANGS
42541a7 
Rename LANGS variable in init.sh for TESSERACT_LANGS languages as it conflicts with the variable LANGS that is responsible for installing fonts
@dosubot dosubot bot added the size:XS This PR changes 0-9 lines, ignoring generated files. label Dec 16, 2024
@github-actions github-actions bot added the Docker Pull requests that update Docker code label Dec 16, 2024
@dosubot dosubot bot added the Bug Something isn't working label Dec 16, 2024
@Frooodle Frooodle merged commit e273b9a into Stirling-Tools:main Dec 16, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Frooodle Frooodle Frooodle approved these changes

Assignees
No one assigned
Labels
Bug Something isn't working Docker Pull requests that update Docker code size:XS This PR changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Bug]: env TESSERACT_LANGS overrides env LANGS
2 participants
@omar-ahmed42 @Frooodle