Hardening suggestions for Stirling-PDF / certValidate #2395
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![pixeebot[bot]](https://avatars.githubusercontent.com/in/193111?s=60&v=4){kind=small}
| @@ -44,14 +45,14 @@ private void loadMozillaCertificates() throws Exception { | |||
| boolean inCert = false; | |||
| int certCount = 0; | |||
|
|
|||
| while ((line = reader.readLine()) != null) { | |||
There was a problem hiding this comment.
Replaced with a call that offers an upper bound on the number of characters that will be read before giving up and throwing a security exception
| if (line.startsWith("CKA_VALUE MULTILINE_OCTAL")) { | ||
| inCert = true; | ||
| certData = new StringBuilder(); | ||
| continue; | ||
| } | ||
| if (inCert) { | ||
| if (line.equals("END")) { | ||
| if ("END".equals(line)) { | ||
| inCert = false; |
There was a problem hiding this comment.
Switch order of literals to prevent NullPointerException
dosubot
bot
added
the
size:XS
pixeebot
bot
force-pushed
the
pixeebot/certValidate
branch
from
91fd35f to
558a83f
Compare
pixeebot
bot
force-pushed
the
pixeebot/certValidate
branch
from
558a83f to
720e57f
Compare
Frooodle
approved these changes
Dec 5, 2024
Frooodle
added a commit
that referenced
this pull request
Dec 5, 2024
* verifyCerts * cert info * Hardening suggestions for Stirling-PDF / certValidate (#2395) * Protect `readLine()` against DoS * Switch order of literals to prevent NullPointerException --------- Co-authored-by: pixeebot[bot] <104101892+pixeebot[bot]@users.noreply.github.com> * some basic html excaping and translation fixing --------- Co-authored-by: pixeebot[bot] <104101892+pixeebot[bot]@users.noreply.github.com> Co-authored-by: a <a>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've reviewed the recently opened PR (2394 - PDF Cert validation) and have identified some area(s) that could benefit from additional hardening measures.
These changes should help prevent potential security vulnerabilities and improve overall code quality.
Thank you for your consideration!
🧚🤖 Powered by Pixeebot
Feedback | Community | Docs