Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: page break insertion functionality in Multi Tool #2350

Merged
merged 1 commit into from
Nov 28, 2024

Conversation

omar-ahmed42
Copy link
Contributor

@omar-ahmed42 omar-ahmed42 commented Nov 28, 2024

Description

Problem:

  • Clicking on "Insert Page Break" button didn't insert any page breaks in Multi Tool.

Closes #2349

Checklist

  • I have read the Contribution Guidelines
  • I have performed a self-review of my own code
  • I have attached images of the change if it is UI based
  • I have commented my code, particularly in hard-to-understand areas
  • If my code has heavily changed functionality I have updated relevant docs on Stirling-PDFs doc repo
  • My changes generate no new warnings
  • I have read the section Add New Translation Tags (for new translation tags only)

- Page Break insertion functionality now successfully inserts page breaks upon request
@dosubot dosubot bot added the size:M This PR changes 30-99 lines, ignoring generated files. label Nov 28, 2024
@github-actions github-actions bot added the Front End Issues or pull requests related to front-end development label Nov 28, 2024
@dosubot dosubot bot added the Bug Something isn't working label Nov 28, 2024
@omar-ahmed42 omar-ahmed42 changed the title Fix: page break insertion functionality Fix: page break insertion functionality in Multi Tool Nov 28, 2024
@Frooodle
Copy link
Member

/deploypr

Copy link
Contributor

🚀 PR Test Deployment

Your PR has been deployed for testing!

🔗 Test URL: http://185.252.234.121:2350

This deployment will be automatically cleaned up when the PR is closed.

@Frooodle Frooodle merged commit de9c21b into Stirling-Tools:main Nov 28, 2024
6 checks passed
@Frooodle
Copy link
Member

Thanks again!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Something isn't working Front End Issues or pull requests related to front-end development size:M This PR changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: Inserting a page break in multi tool not working
2 participants