Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix: id for submit button added #2320

Merged
merged 2 commits into from
Nov 24, 2024
Merged

Fix: id for submit button added #2320

merged 2 commits into from
Nov 24, 2024

Conversation

Ludy87
Copy link
Contributor

@Ludy87 Ludy87 commented Nov 24, 2024

Description

Closes #2319

Checklist

  • I have read the Contribution Guidelines
  • I have performed a self-review of my own code
  • I have attached images of the change if it is UI based
  • I have commented my code, particularly in hard-to-understand areas
  • If my code has heavily changed functionality I have updated relevant docs on Stirling-PDFs doc repo
  • My changes generate no new warnings
  • I have read the section Add New Translation Tags (for new translation tags only)

@Ludy87 Ludy87 requested a review from Frooodle as a code owner November 24, 2024 09:31
@dosubot dosubot bot added the size:XS This PR changes 0-9 lines, ignoring generated files. label Nov 24, 2024
@dosubot dosubot bot added the Bug Something isn't working label Nov 24, 2024
@github-actions github-actions bot added the Front End Issues or pull requests related to front-end development label Nov 24, 2024
@Frooodle Frooodle merged commit 4abb0cb into Stirling-Tools:main Nov 24, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Frooodle Frooodle Frooodle approved these changes

Assignees
No one assigned
Labels
Bug Something isn't working Front End Issues or pull requests related to front-end development size:XS This PR changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Bug]: Null submit button for PDF to CSV conversion
2 participants
@Ludy87 @Frooodle