Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixing bug: Add Image makes random changes to image (#2246) #2256

Conversation

thisisrenan
Copy link
Contributor

Description

Fixing the issue where images were distorted when added to pages with a non-zero angle.

Issue: The problem occurred whenever a page with an angle other than 0 was added. The image was treated as if it were being added to a page with a 0-degree angle.

Solution:
The following file was modified:

  • Modified: src/main/resources/static/js/draggable-utils.js

File: draggable-utils.js

The getOverlayedPdfDocument() function was modified so that when a file has an angle different from 0, it is handled correctly based on the angle

Closes #2246

Checklist

  • I have read the Contribution Guidelines
  • I have performed a self-review of my own code
  • I have attached images of the change if it is UI based
  • I have commented my code, particularly in hard-to-understand areas
  • If my code has heavily changed functionality I have updated relevant docs on Stirling-PDFs doc repo
  • My changes generate no new warnings
  • I have read the section Add New Translation Tags (for new translation tags only)

@dosubot dosubot bot added size:L This PR changes 100-499 lines, ignoring generated files. Bug Something isn't working labels Nov 16, 2024
@github-actions github-actions bot added the Front End Issues or pull requests related to front-end development label Nov 16, 2024
@Frooodle
Copy link
Member

Awesome fix this is a long time issue
also closes dup issues
#217
#2074

@Frooodle Frooodle enabled auto-merge (squash) November 16, 2024 08:55
@Frooodle Frooodle merged commit 8dfb594 into Stirling-Tools:main Nov 16, 2024
5 checks passed
@Frooodle
Copy link
Member

Been loving your PRs btw good stuff

@Softbox44
Copy link

I confirm that this works now.
thank you for fixing

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Something isn't working Front End Issues or pull requests related to front-end development size:L This PR changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: Add Image makes function random changes to image
3 participants