Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(helm): support extra env from #2178

Closed
wants to merge 2 commits into from
Closed

feat(helm): support extra env from #2178

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
6a10c56
feat(helm): support extra env from
M0NsTeRRR Nov 4, 2024
27c8ccf
Merge branch 'main' into feat/extraEnvFrom
M0NsTeRRR Nov 10, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 8 additions & 7 deletions chart/stirling-pdf/Chart.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,16 +1,17 @@
apiVersion: v2
appVersion: 0.32.0
description: locally hosted web application that allows you to perform various operations
description:
locally hosted web application that allows you to perform various operations
on PDF files
home: https://github.com/Stirling-Tools/Stirling-PDF
keywords:
- stirling-pdf
- helm
- charts repo
- stirling-pdf
- helm
- charts repo
maintainers:
- name: Stirling-Tools
url: https://github.com/Stirling-Tools/Stirling-PDF
- name: Stirling-Tools
url: https://github.com/Stirling-Tools/Stirling-PDF
name: stirling-pdf-chart
sources:
- https://github.com/Stirling-Tools/Stirling-PDF
- https://github.com/Stirling-Tools/Stirling-PDF
version: 1.1.0
7 changes: 4 additions & 3 deletions chart/stirling-pdf/README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
# stirling-pdf-chart

![Version: 1.0.0](https://img.shields.io/badge/Version-1.0.0-informational?style=flat-square) ![AppVersion: 0.30.1](https://img.shields.io/badge/AppVersion-0.30.1-informational?style=flat-square)
![Version: 1.1.0](https://img.shields.io/badge/Version-1.1.0-informational?style=flat-square) ![AppVersion: 0.31.1](https://img.shields.io/badge/AppVersion-0.31.1-informational?style=flat-square)

locally hosted web application that allows you to perform various operations on PDF files

Expand All @@ -21,7 +21,7 @@ locally hosted web application that allows you to perform various operations on
Add the following repo to use the chart:

```console
helm repo add stirling-pdf https://stirling-tools.github.io/Stirling-PDF
helm repo add stirling-pdf https://docs.stirlingpdf.com/Stirling-PDF/
```

## Values
Expand All @@ -36,7 +36,8 @@ helm repo add stirling-pdf https://stirling-tools.github.io/Stirling-PDF
| deployment.extraVolumes | list | `[]` | Additional volumes |
| deployment.labels | object | `{}` | |
| deployment.sidecarContainers | object | `{}` | of the chart's content, send notifications... |
| envs | list | `[]` | |
| envs | list | `[]` | Environment variables to add to the stirling-pdf pods |
| envsFrom | list | `[]` | Environment variables from secrets or configmaps to add to the stirling-pdf pods |
| extraArgs | list | `[]` | |
| image.pullPolicy | string | `"IfNotPresent"` | |
| image.repository | string | `"frooodle/s-pdf"` | |
Expand Down
4 changes: 4 additions & 0 deletions chart/stirling-pdf/templates/deployment.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -68,6 +68,10 @@ spec:
{{- if .Values.envs }}
{{ toYaml .Values.envs | indent 8 }}
{{- end }}
{{- with .Values.envsFrom }}
envFrom:
{{- toYaml . | nindent 8 }}
{{- end }}
{{- if .Values.extraArgs }}
args:
{{ toYaml .Values.extraArgs | indent 8 }}
Expand Down
8 changes: 8 additions & 0 deletions chart/stirling-pdf/values.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,6 +18,7 @@ commonLabels: {}
# -- Rootpath for the application
rootPath: /

# -- Environment variables to add to the stirling-pdf pods
envs: []
# - name: UI_APP_NAME
# value: "Stirling PDF"
Expand All @@ -30,6 +31,13 @@ envs: []
# - name: APP_LOCALE
# value: "en_GB"

# -- Environment variables from secrets or configmaps to add to the stirling-pdf pods
envsFrom: []
# - configMapRef:
# name: config
# - secretRef:
# name: config

deployment:
# -- Stirling-pdf Deployment annotations
annotations: {}
Expand Down