Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[fix]: check for encryption in PageNumbers #1949

Merged
merged 1 commit into from
Sep 23, 2024
Merged

[fix]: check for encryption in PageNumbers #1949

merged 1 commit into from
Sep 23, 2024

Conversation

maxi322
Copy link
Contributor

@maxi322 maxi322 commented Sep 22, 2024

Description

This commit fixes a crash occurring when trying to add page numbers to a document which is encrypted by an empty password.

Closes -

Checklist

  • I have read the Contribution Guidelines
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • My changes generate no new warnings
  • I have read the section Add New Translation Tags (for new translation tags only)

@maxi322 maxi322 requested a review from Frooodle as a code owner September 22, 2024 18:57
@github-actions github-actions bot added Java Pull requests that update Java code API API-related issues or pull requests labels Sep 22, 2024
@Frooodle
Copy link
Member

Sorry this approach is to singular, it should apply for all pdfbox usages as it's not specific to any single one

@Frooodle
Copy link
Member

Can you add it as a default check for CustomPDDocumentFactory.java
when loading existing files

@maxi322 maxi322 force-pushed the feature/fixcrash branch 3 times, most recently from 17bd470 to 2a72a5e Compare September 23, 2024 18:49
@github-actions github-actions bot removed the API API-related issues or pull requests label Sep 23, 2024
@maxi322 maxi322 marked this pull request as draft September 23, 2024 19:12
@github-actions github-actions bot added the API API-related issues or pull requests label Sep 23, 2024
@maxi322
Copy link
Contributor Author

maxi322 commented Sep 23, 2024

I added it in CustomPDDocumentFactory.java

@maxi322 maxi322 marked this pull request as ready for review September 23, 2024 19:33
@Frooodle Frooodle merged commit 1c6e5df into Stirling-Tools:main Sep 23, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Frooodle Frooodle Frooodle approved these changes

Assignees
No one assigned
Labels
API API-related issues or pull requests Java Pull requests that update Java code
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@maxi322 @Frooodle