Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug fix] Favorite Icon highlighted with yellow color when selected #1934

Merged
merged 7 commits into from
Sep 21, 2024

Conversation

amankhangit
Copy link
Contributor

@amankhangit amankhangit commented Sep 19, 2024

Description

Favorite Icon highlighted with yellow color when selected

Closes #1818

Checklist

  • I have read the Contribution Guidelines
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • My changes generate no new warnings
  • I have read the section Add New Translation Tags (for new translation tags only)

@github-actions github-actions bot added the Front End Issues or pull requests related to front-end development label Sep 19, 2024
@Frooodle
Copy link
Member

Frooodle commented Sep 20, 2024

I think applying it to fill class as a whole doesn't make sense, how about we add it to home.css?
.favorite-icon .material-symbols-rounded.fill or something

also while you there can you add

.favorite-icon:hover .material-symbols-rounded {
  transform: scale(1.2);
}

:P

@amankhangit
Copy link
Contributor Author

sure i will do that

@Frooodle Frooodle merged commit d6e9e8b into Stirling-Tools:main Sep 21, 2024
5 checks passed
@amankhangit amankhangit deleted the bug-fix branch September 21, 2024 16:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Front End Issues or pull requests related to front-end development
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[CSS Bug]: Favourite Icon can be highlighted with yellow color when selected
2 participants