Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix pdfa conversion #1907

Merged
merged 3 commits into from
Sep 15, 2024
Merged

Fix pdfa conversion #1907

merged 3 commits into from
Sep 15, 2024

Conversation

sbplat
Copy link
Member

@sbplat sbplat commented Sep 15, 2024

Description

Fix pdfa conversion

When returning the response back to the client, loading the file using pdfDocumentFactory doesn't work (I think it processes the pdf, which makes it invalid pdf/a) so the output file was read as a byte array.

Closes #1638

Checklist

  • I have read the Contribution Guidelines
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • My changes generate no new warnings
  • I have read the section Add New Translation Tags (for new translation tags only)

@sbplat sbplat requested a review from Frooodle as a code owner September 15, 2024 16:31
@github-actions github-actions bot added Java Pull requests that update Java code Translation API API-related issues or pull requests labels Sep 15, 2024
Copy link
Contributor

github-actions bot commented Sep 15, 2024

🚀 Translation Verification Summary

📋 Checking with the file messages_en_GB.properties from the pr-branch - Checking the pr-branch

🗂️ Checking File: messages_ar_AR.properties...

  • Test 1 Status: ✅ Passed
  • Test 2 Status: ✅ Passed

🗂️ Checking File: messages_bg_BG.properties...

  • Test 1 Status: ✅ Passed
  • Test 2 Status: ✅ Passed

🗂️ Checking File: messages_ca_CA.properties...

  • Test 1 Status: ✅ Passed
  • Test 2 Status: ✅ Passed

🗂️ Checking File: messages_cs_CZ.properties...

  • Test 1 Status: ✅ Passed
  • Test 2 Status: ✅ Passed

🗂️ Checking File: messages_da_DK.properties...

  • Test 1 Status: ✅ Passed
  • Test 2 Status: ✅ Passed

🗂️ Checking File: messages_de_DE.properties...

  • Test 1 Status: ✅ Passed
  • Test 2 Status: ✅ Passed

🗂️ Checking File: messages_el_GR.properties...

  • Test 1 Status: ✅ Passed
  • Test 2 Status: ✅ Passed

🗂️ Checking File: messages_en_US.properties...

  • Test 1 Status: ✅ Passed
  • Test 2 Status: ✅ Passed

🗂️ Checking File: messages_es_ES.properties...

  • Test 1 Status: ✅ Passed
  • Test 2 Status: ✅ Passed

🗂️ Checking File: messages_eu_ES.properties...

  • Test 1 Status: ✅ Passed
  • Test 2 Status: ✅ Passed

🗂️ Checking File: messages_fr_FR.properties...

  • Test 1 Status: ✅ Passed
  • Test 2 Status: ✅ Passed

🗂️ Checking File: messages_ga_IE.properties...

  • Test 1 Status: ✅ Passed
  • Test 2 Status: ✅ Passed

🗂️ Checking File: messages_hi_IN.properties...

  • Test 1 Status: ✅ Passed
  • Test 2 Status: ✅ Passed

🗂️ Checking File: messages_hr_HR.properties...

  • Test 1 Status: ✅ Passed
  • Test 2 Status: ✅ Passed

🗂️ Checking File: messages_hu_HU.properties...

  • Test 1 Status: ✅ Passed
  • Test 2 Status: ✅ Passed

🗂️ Checking File: messages_id_ID.properties...

  • Test 1 Status: ✅ Passed
  • Test 2 Status: ✅ Passed

🗂️ Checking File: messages_it_IT.properties...

  • Test 1 Status: ✅ Passed
  • Test 2 Status: ✅ Passed

🗂️ Checking File: messages_ja_JP.properties...

  • Test 1 Status: ✅ Passed
  • Test 2 Status: ✅ Passed

🗂️ Checking File: messages_ko_KR.properties...

  • Test 1 Status: ✅ Passed
  • Test 2 Status: ✅ Passed

🗂️ Checking File: messages_nl_NL.properties...

  • Test 1 Status: ✅ Passed
  • Test 2 Status: ✅ Passed

🗂️ Checking File: messages_no_NB.properties...

  • Test 1 Status: ✅ Passed
  • Test 2 Status: ✅ Passed

🗂️ Checking File: messages_pl_PL.properties...

  • Test 1 Status: ✅ Passed
  • Test 2 Status: ✅ Passed

🗂️ Checking File: messages_pt_BR.properties...

  • Test 1 Status: ✅ Passed
  • Test 2 Status: ✅ Passed

🗂️ Checking File: messages_pt_PT.properties...

  • Test 1 Status: ✅ Passed
  • Test 2 Status: ✅ Passed

🗂️ Checking File: messages_ro_RO.properties...

  • Test 1 Status: ✅ Passed
  • Test 2 Status: ✅ Passed

🗂️ Checking File: messages_ru_RU.properties...

  • Test 1 Status: ✅ Passed
  • Test 2 Status: ✅ Passed

🗂️ Checking File: messages_sk_SK.properties...

  • Test 1 Status: ✅ Passed
  • Test 2 Status: ✅ Passed

🗂️ Checking File: messages_sr_LATN_RS.properties...

  • Test 1 Status: ✅ Passed
  • Test 2 Status: ✅ Passed

🗂️ Checking File: messages_sv_SE.properties...

  • Test 1 Status: ✅ Passed
  • Test 2 Status: ✅ Passed

🗂️ Checking File: messages_th_TH.properties...

  • Test 1 Status: ✅ Passed
  • Test 2 Status: ✅ Passed

🗂️ Checking File: messages_tr_TR.properties...

  • Test 1 Status: ✅ Passed
  • Test 2 Status: ✅ Passed

🗂️ Checking File: messages_uk_UA.properties...

  • Test 1 Status: ✅ Passed
  • Test 2 Status: ✅ Passed

🗂️ Checking File: messages_vi_VN.properties...

  • Test 1 Status: ✅ Passed
  • Test 2 Status: ✅ Passed

🗂️ Checking File: messages_zh_CN.properties...

  • Test 1 Status: ✅ Passed
  • Test 2 Status: ✅ Passed

🗂️ Checking File: messages_zh_TW.properties...

  • Test 1 Status: ✅ Passed
  • Test 2 Status: ✅ Passed

✅ Overall Check Status: Success

Switch order of literals to prevent NullPointerException

Co-authored-by: pixeebot[bot] <104101892+pixeebot[bot]@users.noreply.github.com>
@Frooodle Frooodle merged commit b13b925 into main Sep 15, 2024
12 checks passed
@sbplat sbplat deleted the fix_pdfa_conversion branch September 15, 2024 17:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
API API-related issues or pull requests Java Pull requests that update Java code Translation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: Error when converting from PDF to PDF/A
2 participants