Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[CSS Bug]: Reduce extra space between input field & button #1829

Closed
1 task done
Vamsi1810 opened this issue Sep 7, 2024 · 3 comments · Fixed by #1848
Closed
1 task done

[CSS Bug]: Reduce extra space between input field & button #1829

Vamsi1810 opened this issue Sep 7, 2024 · 3 comments · Fixed by #1848
Assignees
@dk-talks
Labels
Front End Issues or pull requests related to front-end development good first issue Good for newcomers

Comments

@Vamsi1810
Copy link
Contributor

Installation Method

Docker

The Problem

image

Version of Stirling-PDF

0.28.3

Last Working Version of Stirling-PDF

No response

Page Where the Problem Occurred

http://localhost:8080/remove-image-pdf

Docker Configuration

No response

Relevant Log Output

No response

Additional Information

No response

Browsers Affected

Chrome

No Duplicate of the Issue

  • I have verified that there are no existing issues raised related to my problem.
@Frooodle Frooodle added good first issue Good for newcomers Front End Issues or pull requests related to front-end development labels Sep 7, 2024
@dk-talks
Copy link
Contributor

dk-talks commented Sep 8, 2024 •
edited
Loading

Screenshot 2024-09-08 at 12 41 08 PM

Hi @Vamsi1810, if we try to remove the extra space, there won't be any space left for the progress bar and the "Bored Waiting" button in case the algorithm takes more time. So, either we keep it as it is, or if the space looks unattractive, we can shift the "Bored Waiting" button to the right side.
Or let me increase the space when the progress bar and "Bored Waiting?" button appears. Please Assign this issue to me.

@Frooodle
Copy link
Member

Frooodle commented Sep 8, 2024

"Or let me increase the space when the progress bar and "Bored Waiting?" button appears."
I think this makes sense, dynamically add spacing based on the elements being added/removed

@dk-talks
Copy link
Contributor

dk-talks commented Sep 8, 2024 •
edited
Loading

Working on it, will create a PR once I complete it and setting up the project locally. Thanks

@dk-talks dk-talks mentioned this issue Sep 8, 2024
Merged
5 tasks
Frooodle pushed a commit that referenced this issue Sep 8, 2024
@dk-talks
Fixed reduce extra space between input field & button #1829 (#1848)
765289c 
* Add <br> when Bored Waiting Button Appears

* Added <br> below progress bar as well

* Removed <br>

Two <br> tags were added which were taking lot of space. I dynamically added space when needed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@dk-talks dk-talks

Labels
Front End Issues or pull requests related to front-end development good first issue Good for newcomers
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fixed reduce extra space between input field & button #1829 dk-talks/Stirling-PDF
3 participants
@dk-talks @Vamsi1810 @Frooodle