Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add docker setup and use instructions #85

Closed
wants to merge 2 commits into from
Closed

Add docker setup and use instructions #85

wants to merge 2 commits into from

Conversation

dkrautha
Copy link
Collaborator

Also removed lots of (what I think is now) unnecessary info from the readme, if I've gone overboard feel free to revert some of that

Also removed lots of unnecessary info from the readme, if I've gone overboard feel free to revert some of that
@dkrautha dkrautha added the tooling Marks a change to project tooling and/or support label May 19, 2023
@dkrautha dkrautha requested a review from hydrodog May 19, 2023 17:33
@dkrautha dkrautha self-assigned this May 19, 2023
@dkrautha dkrautha removed the request for review from hydrodog May 22, 2023 14:56
@ahuston-0
Copy link
Collaborator

Hey @dkrautha does this still need review or is it pending some work still. Could take a look later if you'd like

@dkrautha
Copy link
Collaborator Author

It's tested and working on linux, but there's a couple more changes that need to happen to this branch:

  1. Add a GRAIL env var and add $GRAIL/bin to the path because professor kruger asked for it
  2. Almost certainly revert a bunch of the changes to the readme as some are already incorporated in the main branch, and a lot of the windows instructions shouldn't be kept if the docker container isn't working on windows (opening a gui didn't work, but compiling did)
  3. If anybody does seriously want to use docker for development, it should be made clear that their editor experience will likely be subpar if they don't install and configure the editor in the container itself.
  4. Possibly just remove the custom container instructions and just include distrobox instructions, as then theoretically all that should need to be done is installing the editor in the container, and it'd pick up on all the configuration stuff in the user's home directory automatically

@dkrautha dkrautha closed this Dec 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
tooling Marks a change to project tooling and/or support
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants