Change subscription INFO logs to DEBUG level#286
Conversation
Reduce log noise by downgrading two INFO level messages to DEBUG: - "No event_handler, event handling disabled" - "Device rejected subscription request" These messages are not actionable by users and cause excessive log noise when devices are offline or unreachable. This addresses the issue raised in home-assistant/core#158677.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## development #286 +/- ##
============================================
Coverage 72.02% 72.02%
============================================
Files 18 18
Lines 4254 4254
============================================
Hits 3064 3064
Misses 1190 1190 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
Thank you for this PR @ptarjan. You are right that these are not actionable for the user. Lets change these to the debug-level indeed. I do wonder, however, what can be done to make this actionable, or better inform the (home assistant) user. |
|
See https://github.com/StevenLooman/async_upnp_client?tab=readme-ov-file#changes on the Towncrier part. |
|
Thank you. Updated the towncrier. Suggestions for making this more actionable for Home Assistant users: The library already has mechanisms that integrations can use to communicate device status:
For the "Device rejected subscription" case specifically, this often means the device doesn't support eventing. Home Assistant could:
The logging change here just removes the noise; the actionable information is already available through the API for integrations to surface to users in a more meaningful way. |
|
Thanks! Do you want a release with this? |
|
Sure, and then I can bump it in HA. Thanks! |
|
I've released 0.46.1. |
Reduce log noise by downgrading two INFO level messages to DEBUG:
These messages are not actionable by users and cause excessive log noise when devices are offline or unreachable. This addresses the issue raised in home-assistant/core#158677.