Do not crash on empty body on notifications#1
Merged
StevenLooman merged 1 commit intoStevenLooman:masterfrom Jun 23, 2018
Merged
Do not crash on empty body on notifications#1StevenLooman merged 1 commit intoStevenLooman:masterfrom
StevenLooman merged 1 commit intoStevenLooman:masterfrom
Conversation
Owner
|
Thank you for testing with your devices! I'm glad somebody tests it before it is merged into in Home Assistant. I'll merge it and add a unit test later on. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
While testing home-assistant/core#14749 I noticed that it crashes when receiving a notification from a xiaomi wifi speaker (https://www.gearbest.com/speakers/pp_590443.html) -- I'm not sure if empty values are accepted, but I think it's better to avoid crashing here anyway.
Example element (formated for readability):