Include PointCloudTranport on Subscription#331
Merged
SteveMacenski merged 2 commits intoSteveMacenski:ros2from Aug 12, 2025
Merged
Include PointCloudTranport on Subscription#331SteveMacenski merged 2 commits intoSteveMacenski:ros2from
SteveMacenski merged 2 commits intoSteveMacenski:ros2from
Conversation
Signed-off-by: ElSayed ElSheikh <elsayed.elsheikh97@gmail.com>
Signed-off-by: ElSayed ElSheikh <elsayed.elsheikh97@gmail.com>
SteveMacenski
approved these changes
Jul 31, 2025
Owner
SteveMacenski
left a comment
SteveMacenski
left a comment
There was a problem hiding this comment.
@elsayedelsheikh can you link this in with the main PR so I remember to merge this in when that one is ready?
Contributor
Author
Done! |
Contributor
Author
|
@SteveMacenski Don't forget this one! :-) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related to ros-navigation/navigation2#4042
Follow-up to ros-navigation/navigation2#5264
Description of contribution
Do we need PC transport on voxel publisher as well ?