Skip to content

Conversation

@dimasad
Copy link
Contributor

@dimasad dimasad commented Jan 28, 2022


Basic Info

Info Please fill out this column
Ticket(s) this addresses #471
Primary OS tested on Ubuntu 20.04
Robotic platform tested on None, this is a build-time problem only

Description of contribution in a few bullet points

  • I changed the relative imports to absolute ones that work on the package itself and when including from other packages.
  • Removed $catkin_INCLUDE_DIRS from CMakeLists.txt as this is not needed in ROS2/ament (see https://docs.ros.org/en/foxy/Contributing/Migration-Guide.html).
  • Removed the "god... getting this to work in ROS2 was a real pain" because the previous solution didn't get it to fully work. I also believe no notice is needed now because the solution is standard.

Description of documentation updates required from your changes

None, as far as I know.


Future work that may be required in bullet points

None, as far as I know.

Copy link
Owner

@SteveMacenski SteveMacenski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please submit a PR for ros2 branch. That way this will be reflected in all future distributions. I usually backport to galactic myself, but I can use this one instead then!

@SteveMacenski SteveMacenski merged commit f449abf into SteveMacenski:galactic Jan 28, 2022
@dimasad dimasad deleted the fix-relative-imports branch February 2, 2022 18:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants