Skip to content

Reverted solver blocks removal that crashes multiple initial poses [foxy]#441

Merged
SteveMacenski merged 1 commit intoSteveMacenski:foxy-develfrom
Kaetera:foxy-devel
Oct 25, 2021
Merged

Reverted solver blocks removal that crashes multiple initial poses [foxy]#441
SteveMacenski merged 1 commit intoSteveMacenski:foxy-develfrom
Kaetera:foxy-devel

Conversation

@Kaetera
Copy link
Contributor

@Kaetera Kaetera commented Oct 20, 2021

Basic Info

Info Please fill out this column
Ticket(s) this addresses #419
Primary OS tested on Ubuntu 20.04, ROS2 Foxy
Robotic platform tested on Custom diff drive real robot

Description of contribution in a few bullet points

Fixed crashes when setting initial poses, but may re-introduce warnings these lines avoided.

Description of documentation updates required from your changes

N/A


Future work that may be required in bullet points

As mentioned in the ticket's discussion this fixes the issue until a "better scan management" is implemented.

@SteveMacenski
Copy link
Owner

Can you submit across the current branches with it? Just to keep everything aligned. Then I'll reopen #398 with a note about why we reverted it.

@Kaetera
Copy link
Contributor Author

Kaetera commented Oct 25, 2021

Done.
I did not figure out how to put commits from several branches in the same PR so I opened #443 and #444 .
Note I could not test the compilation/the run since I only have Foxy installed.

@SteveMacenski SteveMacenski merged commit df24dc0 into SteveMacenski:foxy-devel Oct 25, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants