Add semantic checks to avoid NPE in Mapper.#434
Merged
SteveMacenski merged 1 commit intoSteveMacenski:ros2from Sep 9, 2021
Merged
Add semantic checks to avoid NPE in Mapper.#434SteveMacenski merged 1 commit intoSteveMacenski:ros2from
SteveMacenski merged 1 commit intoSteveMacenski:ros2from
Conversation
Signed-off-by: zouyonghao <yonghaoz1994@gmail.com>
SteveMacenski
requested changes
Sep 8, 2021
| } | ||
| node_->get_parameter("max_laser_range", max_laser_range); | ||
|
|
||
| if (max_laser_range <= 0) { |
Owner
There was a problem hiding this comment.
Is this a real issue you really ran into? This seems like its from a poorly formed laser scan message and it should be fixed by the publisher
Contributor
Author
There was a problem hiding this comment.
I just consider it as a parameter a user can set, and it seems it is not related to scan message...
SteveMacenski
approved these changes
Sep 9, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Signed-off-by: zouyonghao yonghaoz1994@gmail.com
Basic Info
Description of contribution in a few bullet points