Correct Rolling compile errors and warnings#431
Closed
destogl wants to merge 1 commit intoSteveMacenski:ros2from
Closed
Correct Rolling compile errors and warnings#431destogl wants to merge 1 commit intoSteveMacenski:ros2from
destogl wants to merge 1 commit intoSteveMacenski:ros2from
Conversation
SteveMacenski
requested changes
Aug 26, 2021
Owner
SteveMacenski
left a comment
SteveMacenski
left a comment
There was a problem hiding this comment.
LGTM, just need to use the right declare in parameter updates
| { | ||
| auto temp_node = std::make_shared<rclcpp::Node>("slam_toolbox"); | ||
| temp_node->declare_parameter("stack_size_to_use"); | ||
| temp_node->declare_parameter("stack_size_to_use", stack_size); |
Owner
There was a problem hiding this comment.
This should be a type declaration, not a default declaration. This was intentionally not including a default so it uses system defaults when not manually overrided.
Owner
There was a problem hiding this comment.
e.g.
temp_node->declare_parameter("stack_size_to_use", rclcpp::PARAMETER_INTEGER);
Owner
|
@destogl any update? |
Owner
|
Handling this myself to speed it up, PR #436 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR contains trivial changes, mostly about missing includes, to get ros2 branch compiled under rolling.
I also resolve a deprecation warning about
declare_parameterwithout a value.